Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): resolve parsing issues with raw/endraw in Jinja #824

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix(template): resolve parsing issues with raw/endraw in Jinja #824

merged 1 commit into from
Aug 29, 2024

Conversation

pplmx
Copy link
Contributor

@pplmx pplmx commented Aug 28, 2024

Description

This pull request removes the usage of {% raw %} and {% endraw %} tags from the template files. The presence of these tags caused parsing issues for higher-level callers that also utilize the Jinja engine.

Motivation and Context

The change is necessary because using {% raw %} and {% endraw %} tags can interfere with the correct parsing of templates by higher-level callers using the Jinja engine. This modification ensures compatibility and proper parsing for all Jinja-based template users. This PR addresses an issue where templates could not be parsed correctly due to the conflict caused by these tags.

closes #818

How Has This Been Tested?

Tested.

Screenshots / Logs (if applicable)

N/A

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pplmx pplmx requested a review from orhun as a code owner August 28, 2024 14:13
Copy link

welcome bot commented Aug 28, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.19%. Comparing base (c34aaa0) to head (22e6f2b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   40.19%   40.19%           
=======================================
  Files          20       20           
  Lines        1645     1645           
=======================================
  Hits          661      661           
  Misses        984      984           
Flag Coverage Δ
unit-tests 40.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@orhun orhun changed the title fix(template): raw and endraw prevent correct parsing by higher-level callers using the Jinja engine fix(template): resolve parsing issues with raw/endraw in Jinja Aug 29, 2024
@orhun orhun merged commit 63bf5b7 into orhun:main Aug 29, 2024
120 checks passed
Copy link

welcome bot commented Aug 29, 2024

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants