Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] context data are missing #801

Closed
1 task done
marcaurele opened this issue Aug 18, 2024 · 2 comments
Closed
1 task done

[gitlab] context data are missing #801

marcaurele opened this issue Aug 18, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@marcaurele
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

When using the GitLab integration feature, the gitlab block in the contextual data is empty from all its information. Therefore the username handle, nor the MR number is available to create useful links in the changelog.

Relates to #687

Steps To Reproduce

Configure cliff.toml as described for the Gitlab integration at https://git-cliff.org/docs/integration/gitlab

Expected behavior

The context data should contain:

  • the technical username usable with @ handle
  • the MR number related to the commit under pr_number
  • the MR title under pr_title
  • the MR labels under pr_labels

Screenshots / Logs

Content is truncated / redacted to hide some information:

$ git-cliff --context --unreleased
[
  {
    "version": null,
    "message": null,
    "commits": [
      {
        "id": "e3b4e5149e42fae29589e00e27e8e05cbc0532c5",
        "message": "update dependency sentry-sdk to ~=2.12.0",
        "body": null,
        "footers": [
          {
            "token": "Changelog",
            "separator": ":",
            "value": "dependencies",
            "breaking": false
          }
        ],
        "group": "Bug Fixes",
        "breaking_description": null,
        "breaking": false,
        "scope": "deps",
        "links": [],
        "author": {
          "name": "Firstname Lastname",
          "email": "[email protected]",
          "timestamp": 1723374230
        },
        "committer": {
          "name": "Firstname Lastname",
          "email": "[email protected]",
          "timestamp": 1723374230
        },
        "conventional": true,
        "merge_commit": false,

        "gitlab": {
          "username": null,
          "pr_title": null,
          "pr_number": null,
          "pr_labels": [],
          "is_first_time": false
        },
        ...
      },
      ...

Software information

  • Operating system: Linux Debian
  • Project version: 2.4.0

Additional context

This relates to the comment:

I thought it would be easier to start another issue. Feel free to close that one @orhun if you prefer.

@marcaurele marcaurele added the bug Something isn't working label Aug 18, 2024
Copy link

welcome bot commented Aug 18, 2024

Thanks for opening your first issue at git-cliff! Be sure to follow the issue template! ⛰️

@marcaurele marcaurele changed the title [gitlab] context data are missing or incorrect [gitlab] context data are missing Aug 18, 2024
@orhun
Copy link
Owner

orhun commented Aug 18, 2024

I think it would make more sense to continue in #687 since it has more history about the cause and fix for this problem.

I hope @tonybutt enlightens us about his fix in #687 (comment) soon :)

@marcaurele marcaurele closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants