Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): allow using environment variables without config file present #783

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Aug 4, 2024

Motivation and Context

fixes #777

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.97%. Comparing base (4b33e7e) to head (d4b3b85).

Files Patch % Lines
git-cliff-core/src/embed.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   37.03%   36.97%   -0.06%     
==========================================
  Files          20       20              
  Lines        1542     1542              
==========================================
- Hits          571      570       -1     
- Misses        971      972       +1     
Flag Coverage Δ
unit-tests 36.97% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun force-pushed the fix/allow_using_env_without_config_file branch from d4b3b85 to 2b0364a Compare August 6, 2024 12:58
@orhun orhun merged commit 2471745 into main Aug 6, 2024
30 of 31 checks passed
@orhun orhun deleted the fix/allow_using_env_without_config_file branch August 6, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config environment variables are not respected when cliff.toml is not found
2 participants