Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GIT_CLIFF_ prefix to environment variables #74

Closed
uyha opened this issue Apr 1, 2022 · 1 comment
Closed

Add GIT_CLIFF_ prefix to environment variables #74

uyha opened this issue Apr 1, 2022 · 1 comment
Assignees
@orhun
Labels
feature/request New feature or request

Comments

@uyha
Copy link
Contributor

uyha commented Apr 1, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, git-cliff uses many environment variables without prefixing it with GIT_CLIFF_, which causes surprises when I have set up environment variables like CONFIG in my startup script and then git-cliff behaves weirdly.

Describe the solution you'd like
Prefixing all environment variables with GIT_CLIFF_

Describe alternatives you've considered
Prefixing all environment variable with CLIFF_
@uyha uyha added the feature/request New feature or request label Apr 1, 2022
@uyha uyha mentioned this issue Apr 4, 2022
Merged
10 tasks
@kaushalmodi kaushalmodi mentioned this issue Apr 4, 2022
Closed
@kaushalmodi
Copy link
Contributor

kaushalmodi commented Apr 4, 2022 •
edited
Loading

Thanks. This issue was causing problem in #75 because I had INCLUDE_PATH set for GCC which was clashing with git cliff's INCLUDE_PATH. I confirm that #76 fixes that issue.

@uyha uyha closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orhun orhun

Labels
feature/request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kaushalmodi @uyha @orhun