Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add another option of GitHub Actions #64

Merged
merged 3 commits into from
Mar 6, 2022

Conversation

kenji-miyake
Copy link
Contributor

Description

Added a description of setup-git-cliff as another option of GitHub Actions.

Motivation and Context

Discussed at #59 (comment).

How Has This Been Tested?

Not applicable.

Screenshots / Output (if appropriate):

Not applicable

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • [Not applicable] I have added tests to cover my changes.
  • All new and existing tests passed.

@kenji-miyake kenji-miyake requested a review from orhun as a code owner March 6, 2022 16:28
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2022

Codecov Report

Merging #64 (99ad482) into main (3ccec7f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   40.44%   40.44%           
=======================================
  Files          13       13           
  Lines         831      831           
  Branches      219      218    -1     
=======================================
  Hits          336      336           
  Misses        386      386           
  Partials      109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccec7f...99ad482. Read the comment docs.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I think we should mention the difference, though.

README.md Outdated Show resolved Hide resolved
@orhun
Copy link
Owner

orhun commented Mar 6, 2022

Thanks for the PR! I will merge when the checks are complete.

I have one request: do you mind joining the git-cliff matrix room? I think it would be easier for us to communicate there for project-related matters since you are a long-time contributor. (Of course, only if you want to 😊) I'm requesting this because I'm thinking of moving cliff-related repositories to git-cliff organization and I'm not sure where to contact you about that. (GitHub issues? lol)

@orhun orhun changed the title docs(README.md): add another option of GitHub Actions docs(readme): add another option of GitHub Actions Mar 6, 2022
@orhun orhun merged commit db7edf5 into orhun:main Mar 6, 2022
@kenji-miyake kenji-miyake deleted the update-readme branch March 7, 2022 00:07
@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented Mar 7, 2022

@orhun Thank you for inviting me! I'll investigate which client is suitable for me and join the channel. (Which client do you use or recommend?)

image

I'm not sure where to contact you about that. (GitHub issues? lol)

By the way, I guess GitHub Discussions could be a good place for the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants