chore(pypi): update maturin version #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use of `[package.metadata.maturin.name]` is deprecated and warned against: `Warning: specify [package.metadata.maturin] name in Cargo.toml is deprecated, use module-name in [tool.maturin] section in pyproject.toml instead`
the previously pinned version was way too specific and maturin has since had a 1.0 release -- so let's just stick with that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
=======================================
Coverage 41.14% 41.14%
=======================================
Files 15 15
Lines 1038 1038
=======================================
Hits 427 427
Misses 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
orhun
approved these changes
Mar 7, 2024
orhun
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've updated the maturin version, addressed a deprecation warning, and added a .gitignore file to the pypi folder to ignore files that are generated during build and local testing.
Motivation and Context
I discovered that the version of maturin specified in
pyproject.tomlwas too narrowly constrained in the process of investigating #534.How Has This Been Tested?
I ran the
maturin buildcommand that is normally run in GHA locally, and confirmed that it builds an installable wheel on my platform (Windows).Types of Changes
Checklist: