Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check semver violations via CI #334

Closed
orhun opened this issue Oct 30, 2023 · 0 comments
Closed

Check semver violations via CI #334

orhun opened this issue Oct 30, 2023 · 0 comments
Labels
feature/request New feature or request good first issue Good for newcomers

Comments

@orhun
Copy link
Owner

orhun commented Oct 30, 2023

Is your feature request related to a problem? Please describe.

The last release of git-cliff-core had a breaking change:

error[E0063]: missing fields `field` and `pattern` in initializer of `CommitParser`
   --> crates/release_plz_core/src/changelog.rs:192:9
    |
192 |         CommitParser {
    |         ^^^^^^^^^^^^ missing `field` and `pattern`

And we don't have the processes set up to check these kind of situations during the development phase.

Describe the solution you'd like

Use cargo-semver-checks in CI via cargo-semver-checks-action.

Describe alternatives you've considered

Add cargo-semver-checks to the release script for checking the semver violations before the release.

Additional context

@orhun orhun added feature/request New feature or request good first issue Good for newcomers labels Oct 30, 2023
@orhun orhun closed this as completed in a25a114 Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant