-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(changelog): fix typos #316
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. 📢 Thoughts on this report? Let us know!. |
Can you maybe update the release script to check if if ! command -v typos &>/dev/null; then
echo "typos is not installed. Run 'cargo install typos' to install it otherwise the typos won't be checked"
fi Also, one other thing to note, the CD workflows ( |
@orhun I added both in f1983ec.
|
Got it, I think that's fine. Let's see how it goes. |
Congrats on merging your first pull request! ⛰️ |
Oops, I think we need to install
Logs: https://github.com/orhun/git-cliff/actions/runs/6683630522/job/18160024949 |
fixes #310
Description
Fix the typos in the changelog and automate typos correction in the changelog generation.
Motivation and Context
#310
How Has This Been Tested?
On my machine at the moment. I expect the next release to reveal if it breaks or not. Note that
release.sh
will now depend ontypos
being installed on the machine. Not sure if I should document that somewhere.Types of Changes
Checklist: