tofuutils
Replies: 6 comments 15 replies
-
|
@coolapso it's a great catch! I will look that this deeper and return to this thread |
Beta Was this translation helpful? Give feedback.
-
|
I have no insights on the tenv codebase but I would be more than happy to contribute in trying implement the change given there's an agreement on how it should be done :) |
Beta Was this translation helpful? Give feedback.
-
|
I understand that these feature interaction could lead to issues. However inserting a breaking change in default behavior of tenv doesn't feel that great to me... Moreover, there is several way to disable the auto install feature ( In my opinion, the best path of action for tenv project is to warn users in the documentation in a noticeable way. |
Beta Was this translation helpful? Give feedback.
-
|
I agree with @coolapso that behavior is dangerous and users don't read documentation :( We have to save our users from actions that they didn't expect. |
Beta Was this translation helpful? Give feedback.
-
|
Some usage (as in tofuutils/tenv#93) rely on tenv detection and auto install. However you are right, it is less dangerous to default to auto install disabled. I will do that easy change (and prepare myself for chaos, you admit people do not read the doc, so even if we try to warn them 😅) |
Beta Was this translation helpful? Give feedback.
-
|
Merged, @kvendingoldo, I let you communicate on this and trigger a release when you think that's ok (should be a 2.0.0 in my opinion, as this is a change not additionnal features). |
Beta Was this translation helpful? Give feedback.
-
|
released 2.0.0. |
Beta Was this translation helpful? Give feedback.
-
|
did a few tests seems to be okay: Completely remove terraform / terragrunt / tofu tenv did not auto install any of them when trying to execute them. I would say everything looks okay. |
Beta Was this translation helpful? Give feedback.
-
|
Original thread from tofuenv: tofuutils/tofuenv#41 |
Beta Was this translation helpful? Give feedback.
-
|
Hi guys, sorry I wake up late on this, but to me the core issue is NOT the This right fix to me would have been:
instead of:
Keep the main usage pattern as easy and enjoyable as possible. Don't put extra unecessary burden just for a small % of users. |
Beta Was this translation helpful? Give feedback.
-
|
we can see it in many possible ways and regardless of what terragrunt reasons for doing whatever they did the facet is ... no tool should install other tools / binaries automatically by default, period. That becomes even more critical when such tool manages 3 different tools. Also you should never rely on the default behavior of something you can't control. because such behavior can always change as we just saw. if you want that behavior then the users should enable it explicitly. I believe I've reasoned about this enough. |
Beta Was this translation helpful? Give feedback.
-
|
Though I understand what you say about tools that shouldn't install things on its own by default, in some cases, I would say it's acceptable, and What also tells me that the fix for this issue may not suit the majority of users is this: Now suddenly, from a small base of This indicates that the real issue is from the TG users rather then the Tofu/TF users. TG tries to use Now, the decision, implementation and releases have been made, but at least, I have raised my concerns about the way this TG issue has been addressed. |
Beta Was this translation helpful? Give feedback.
-
|
because it has been like that for years doesn't necessarily mean its correct :) |
Beta Was this translation helpful? Give feedback.
-
|
Hi guys .. Wondering is the variable TENV_AUTO_INSTALL default to false now ? We have around 50+ pipelines using the tenv image started failing as we updated the image and we were forced to update environment variables to add TENV_AUTO_INSTALL=true for all. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, the TENV_AUTO_INSTALL default to false since v2.0.0, this breaking change is the reason why we increase major version (see this pull request) |
Beta Was this translation helpful? Give feedback.
-
|
also, you can read it here: https://hackernoon.com/tenv-v20-the-importance-of-explicit-behavior-for-the-version-manager |
Beta Was this translation helpful? Give feedback.
-
Hi all ... bringing up this discussion to propose a change in a default behavior of tenv.
Today I had a quite unpleasant surprise with terragrunt and tenv, which could have caused major issues. On a fresh install of my work system when executing terragrunt, I ended up using Tofu instead of Terraform, gladly this time, it was on a completely new terraform state on a development environment. now I wonder if this was the cause of some terraform state issues some days ago.
By default tenv seems to have some sort of catchall that automatically installs the latest terraform / tofu / terragrunt if the application is executed and the binary doesn't exist.
While this feature hasn't been problematic in the standalone version managers, because users tipically have one, or the other, it becomes problematic when there are multiple of them at the same time. Because terragrunt is calling OpenTofu by default and causing tenv to install tofu, unaware (like myself today) users suddenly can see them using OpenTofu instead of terraform because, and this can be quite dangerous!
Sure it can be controlled by the
TERRAGRUNT_TFPATHvariable, but this default behavior in this "multi tool" environment allied with poor communication and users distractions is not the best experience, specially when no breaking changes communicated, also default behaviors can always change and a tool such as tenv should be as decoupled as possible from those default behaviors and I believe this feature should be OFF by default and controlled wither with some flags, environment variables, dotfile on the${HOME}/.config/.Here's some other discussion about this: gruntwork-io/terragrunt#3172 (comment)
Thanks a lot for the hard work :)
Beta Was this translation helpful? Give feedback.
All reactions