Resolving {cfr} blocker dependencies #85
Replies: 6 comments 11 replies
-
Minor comment. IMO - the {outbreaks} README needs updating as I think the "hackathon" part is a remnant and misleading. AFAIK the package is aiming to be a more centralised provider for example data. I'm not the maintainer though so could you raise an issue to clarify? |
Beta Was this translation helpful? Give feedback.
-
I am happy to help here too. This is where a typical sprint could help complete it in a few days. |
Beta Was this translation helpful? Give feedback.
-
In preparation to release {bpmodels} on CRAN, I had to remove {epiparameter} as a Suggested package because it was used in the vignette. However, I plan to revert to its use once it's on CRAN. |
Beta Was this translation helpful? Give feedback.
-
It would take a huge effort to put covidregionaldata back on CRAN, and its functionality would likely be severely reduced as multiple data sources disappeared after the peak of the epidemic. I don't think it's likely to ever make it back on CRAN. outbreaks is a good option and is already used in linelist. A custom minimal dataset could be a good option as well. |
Beta Was this translation helpful? Give feedback.
-
I think having as stable {epiparameter} release to go to CRAN for the end of August is realistic. This is after the CRAN summer break. Happy to discuss and adjust is {cfr} needs to go to CRAN sooner than this. |
Beta Was this translation helpful? Give feedback.
-
Closing as this issue has been resolved in epiverse-trace/cfr#88 and epiverse-trace/cfr#58 |
Beta Was this translation helpful? Give feedback.
-
This discussion is aimed at moving {cfr} closer to an initial release on CRAN.
{cfr} relies on two dependencies that are not on CRAN, {epiparameter} and {covidregionaldata}. {epiparameter} is imported and is key to how {cfr} handles delay distributions, while {covidregionaldata} is only suggested and is used in the vignettes (and was used in some examples, but see draft PR 58 in the {cfr} repo).
{cfr} cannot be released to CRAN until these two dependencies are resolved, i.e., either removed or put on CRAN themselves.
{covidregionaldata}
{covidregionaldata} could be removed and a snapshot of the UK covid data used from {incidence2} instead - but this would disallow a very nice cross-country comparison in one of the vignettes. This is relevant since we have identified LMIC rather than UK examples as something we want to include more of.
One alternative would be to download some of that data and contribute a snapshot of it to another package such as {outbreaks}. However, {oubreaks}' Readme still says "the purpose of the current package is only to share examplar datasets during the hackathon" and the package was last updated on CRAN in 2020. So this might not be a quick solution - does anybody have an estimate of how this might go?
A second alternative would be to include this data within {cfr} itself, as it already includes an ebola dataset.
In any case, it would be good to hear thoughts from @Bisaloo or @sbfnk as among those in Epiverse involved with {covidregionaldata}.
{epiparameter}
This is a key dependency, so unlikely to be removed - is there any chance we could get a timeline for when it might get to CRAN? I'd be happy to pitch in if some focused work is required to make progress on that. Pinging @adamkucharski and @joshwlambert for thoughts.
Beta Was this translation helpful? Give feedback.
All reactions