GitHub keys signed commits shouldn't be treated the same as personally signed ones, nor shown as committed by the author #144632
Replies: 1 comment 1 reply
-
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Bug
Body
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Title: GitHub keys signed commits shouldn't be treated the same as personally signed ones, nor shown as committed by the author
I always sign my commits to open source projects. However, in certain circumstances, e.g. squashed PRs, these signatures were dropped, and the commits are signed by GitHub's keys instead (currently B5690EEEBB952194), but still shown as committed by me with the same Verified badge as if it's signed with my keys. This is unacceptable.
First, the signatures prove the commits came from the signer. Signed with GitHub's keys, they instead prove they are presented by GitHub. This only provides a much weaker proof, that the commits were accepted on genuine GitHub interfaces (Web edits) and/or genuinely generated by GitHub (squashed PRs). Commit signatures shouldn't and couldn't be used for that.
Second, when signed with GitHub's keys, the commits are made by GitHub. On that basis, these commits should have GitHub as the committer. Keeping the original committer is dishonest.
Third, the Verified badges assert commit signatures are good. With the first point in mind, GitHub keys signed commits shouldn't be presented the same as personally signed ones, mixing two completely different concepts.
Thus I ask that 1) an option be provided that, when one signs commits with their own keys, GitHub does not re-sign them; 2) mark GitHub generated commits as such, with GitHub being the committer; and 3) distinguish those GitHub signed from those personally signed in the Verified badge.
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQScTWEJ927Sl0a/hB7sV97Kb1Pv6QUCZzbbgAAKCRDsV97Kb1Pv
6Zt0AP0WZYFXz+/mCMVqlEYqoSbIai6mWR9mdGgStoywT7oVCQEApWMGcUu834ZD
xbyaElJPoY6qpV98UPPgpMYkPuUphQk=
=0Gja
-----END PGP SIGNATURE-----
Beta Was this translation helpful? Give feedback.
All reactions