Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The benchmark results in an error but the check shows success #289

Open
MahdiBM opened this issue Oct 8, 2024 · 2 comments
Open

The benchmark results in an error but the check shows success #289

MahdiBM opened this issue Oct 8, 2024 · 2 comments

Comments

@MahdiBM
Copy link
Contributor

MahdiBM commented Oct 8, 2024

swift package --disable-sandbox \
      benchmark thresholds check \
      --path $PWD/Benchmarks/Thresholds/ \
      --format markdown

succeeds when the actual benchmark has resulted in an error.

@hassila
Copy link
Contributor

hassila commented Oct 9, 2024

You mean if the benchmark crashed, or?

@MahdiBM
Copy link
Contributor Author

MahdiBM commented Oct 9, 2024

No the benchmark run doesn't crash. It simply throws an error.

I noticed the benchmark says Checking ["benchmark name 1", "benchmark name 2"] around the end, but if the benchmark run has resulted in an error, it doesn't mention that benchmark's name in there at all.

Probably all benchmark runs for a specific benchmark must fail for this to happen.
Then the Benchmarking package doesn't have any results for that certain benchmark to compare to, so it simply skips the comparison instead of complaining that where are the results that I'm supposed to compare to or something. It should just fail the benchmark comparison if any of the benchmarks resulted in an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants