Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send command #618

Merged
merged 13 commits into from
Oct 7, 2022
Merged

send command #618

merged 13 commits into from
Oct 7, 2022

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Oct 4, 2022

No description provided.

@raphjaph raphjaph requested a review from casey October 6, 2022 19:02
@raphjaph raphjaph marked this pull request as ready for review October 6, 2022 19:03
casey
casey requested changes Oct 6, 2022
View reviewed changes
src/options.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/subcommand/wallet/send.rs Show resolved Hide resolved
src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved
test-bitcoincore-rpc/src/lib.rs Outdated Show resolved Hide resolved
tests/command_builder.rs Outdated Show resolved Hide resolved
tests/wallet.rs Outdated Show resolved Hide resolved
@raphjaph raphjaph requested a review from casey October 7, 2022 11:19
casey
casey requested changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of minor stuff, but overall this looks great.

test-bitcoincore-rpc/src/lib.rs Outdated Show resolved Hide resolved
test-bitcoincore-rpc/src/lib.rs Outdated Show resolved Hide resolved
test-bitcoincore-rpc/src/lib.rs Outdated Show resolved Hide resolved
test-bitcoincore-rpc/src/lib.rs Outdated Show resolved Hide resolved
test-bitcoincore-rpc/src/lib.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/send.rs Show resolved Hide resolved
src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved
@raphjaph raphjaph requested a review from casey October 7, 2022 18:42
casey
casey approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a send command!

@casey casey enabled auto-merge (squash) October 7, 2022 18:51
@casey casey merged commit 80f0536 into ordinals:master Oct 7, 2022
@raphjaph raphjaph deleted the send-command branch October 7, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphjaph @casey