Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index in Index::open #545

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Update index in Index::open #545

merged 1 commit into from
Sep 21, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Sep 21, 2022

It's never useful to have an unsynced index, so do it on open, and rename Index::index_ranges to just Index::index.

@casey
Copy link
Collaborator Author

casey commented Sep 21, 2022

@raphjaph This is little refactor of the index. It removes the Index::index static method which opens and syncs an index in favor of always syncing the index in Index::open, and renames Index::index_ranges to Index::index, since Index::index_ranges sounds more like it's something specialized. Take a look!

@casey casey requested a review from raphjaph September 21, 2022 22:08
raphjaph
raphjaph approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this makes sense. We should probably merge this and rebase #544 on top.

@casey casey merged commit d0600bb into master Sep 21, 2022
@casey casey deleted the index-on-open branch September 21, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph