Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing section #2261

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Add contributing section #2261

merged 5 commits into from
Jul 10, 2023

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Jul 10, 2023

Closes #2260

README.md Outdated
```

We also try to follow a TDD (Test-Driven-Development) approach, which means we
use tests as a way to get view inside the code. Tests have to run fast for that
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with "get view"? Get visibility? Not quite sure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I mean visibility. Will reformulate

Copy link
Collaborator

@veryordinally veryordinally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captures all the key points! Minor language comment.

@raphjaph raphjaph enabled auto-merge (squash) July 10, 2023 11:30
@raphjaph raphjaph merged commit 6b99112 into ordinals:master Jul 10, 2023
@boring877
Copy link

Clowns, Good Engineer But Bad Bad Development Plans.

sidmorizon added a commit to OneKeyHQ/ord that referenced this pull request Aug 1, 2023
* Add contributing section (ordinals#2261)

* Implement clean index shutdown to prevent index corruption (with clippy updates for Rust 1.71) (ordinals#2275)

* gracefully shutdown index update thread to prevent index corruption

* Use `next_back()` instead of `rev().next()` for rust 1.71

---------

Co-authored-by: victorkirov <[email protected]>

* Modify `ord list` output to include the end of each range (ordinals#1998)

* Don't create default data directory if --index overrides it (ordinals#1991)

* Fix docs inconsistency (ordinals#2276)

* Fix ordering for reinscriptions and show all reinscriptions for sat (ordinals#2279)

* Add satpoint and address to index export (ordinals#2284)

* Update bitcoin dependencies (ordinals#2281)

* Update redb (ordinals#2294)

* Add retry to fetcher (ordinals#2297)

* Clean up deploy scripts (ordinals#2298)

* Fix justfile recipe (ordinals#2299)

* Release 0.8.1 (ordinals#2300)

* Add `amount` field to `wallet inscriptions` output. (ordinals#1928)

* Fix dust limit for padding in `TransactionBuilder` (ordinals#1929)

* Inform user when redb starts in recovery mode (ordinals#2304)

* Fix remote RPC wallet commands (ordinals#1766)

* Select multiple utxos (ordinals#2303)

Co-authored-by: Greg Martin <[email protected]>

* feat: add outputs api

---------

Co-authored-by: raph <[email protected]>
Co-authored-by: victorkirov <[email protected]>
Co-authored-by: gmart7t2 <[email protected]>
Co-authored-by: ordinally <[email protected]>
Co-authored-by: Carlos Alaniz <[email protected]>
Co-authored-by: Greg Martin <[email protected]>
@raphjaph raphjaph deleted the contributing branch January 31, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write short CONTRIBUTING guide
3 participants