Correct reveal tx fee calculation #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inscribe command would calculate the reveal tx fee incorrectly whenever the reveal tx wasn't funded by the first output of the commit tx as is the case when you inscribe on a satpointvwith a non zero offset. In such cases If the first output of the commit tx was much smaller than the 2nd the inscribe command would fail due to calculating a negative fee. This commit fixes the problem and closes ordinals#1844.
raphjaph
approved these changes
Mar 7, 2023
raphjaph
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inscribe command would calculate the reveal tx fee incorrectly whenever the reveal tx wasn't funded by the first output of the commit tx as is the case when you inscribe on a satpoint with a non zero offset.
In such cases if the first output of the commit tx was much smaller than the 2nd the inscribe command would fail due to calculating a negative fee.
This commit fixes the problem and closes #1844.