Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradiction in runes spec? #3855

Closed
gmart7t2 opened this issue Jul 13, 2024 · 2 comments · Fixed by #3885
Closed

Contradiction in runes spec? #3855

gmart7t2 opened this issue Jul 13, 2024 · 2 comments · Fixed by #3885

Comments

@gmart7t2
Copy link
Contributor

gmart7t2 commented Jul 13, 2024

Screenshot_2024-07-13_12-30-16

Are unknown odd tags ignored or forbidden? It can't be both!

I guess they aren't forbidden because "ord decode" happily decodes the runestone in these 3 txs, which each have unknown odd tags:

  • e6c190a563824cebac0821fece3ea477d6d93a39095dd2b5de8379b56de6ae54
  • e8d4998a4df7c64400d6c05f3caa939ed45d51a301125be1a33db584b9e0a18a
  • 24a0fc977fef46fd6b7661a503a159c2d2e172d7d6905fe28676b1ac3cb30743
@raphjaph
Copy link
Collaborator

raphjaph commented Aug 6, 2024

Yes, they aren't forbidden, just ignored.

I guess we should change the phrasing of the last sentence to ..., and should not be used. It would then conform more to the language used in RFCs. You can use odd tags but it will very likely lead to weird behaviour in the future.

@raphjaph raphjaph added this to Tracker Aug 6, 2024
@raphjaph raphjaph moved this to In Progress in Tracker Aug 6, 2024
@casey casey linked a pull request Aug 6, 2024 that will close this issue
@casey
Copy link
Collaborator

casey commented Aug 6, 2024

Unrecognized odd tags are ignored, but they are reserved, in the sense that future protocol upgrades may give them meaning, and so they should not be used for ad-hoc protocol extensions.

Updating the language in #3885.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants