Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text inscription rendering #1160

Closed
casey opened this issue Jan 4, 2023 · 0 comments · Fixed by #1222
Closed

Improve text inscription rendering #1160

casey opened this issue Jan 4, 2023 · 0 comments · Fixed by #1222

Comments

@casey
Copy link
Collaborator

casey commented Jan 4, 2023 •
edited
Loading

Ideally, text inscriptions should scale up or down to fit the size of the iframe that contains them.

This requires:

  • Knowing which characters will be rendered
  • Knowing which font will be used (and it might be multiple fonts, if there are different scripts and emoji involved)
  • Performing text layout, which is extremely complicated, and so might not be possible server-side

The best option might be to do this in JS:

  • Render text in <pre> tag
  • Scale pre tag up or down to fit iframe
@casey casey added this to the Mainnet milestone Jan 4, 2023
@casey casey changed the title Misc preview fixes Improve text inscription rendering Jan 9, 2023
@casey casey removed this from the Alpha milestone Jan 9, 2023
@casey casey mentioned this issue Jan 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve text rendering ordinals/ord
1 participant
@casey