-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: dist CSS is not mapped in package.json #771
Comments
I'm not understanding the relationship between jsDelivr and Symphony Asset Mapper. Can you explain more? You cite Bootstrap as an example of something that's working correctly. However, the ESM "type" on jsDeliver (https://www.jsdelivr.com/package/npm/bootstrap) also doesn't include any CSS: I'm happy to add a |
The Symfony Asset Mapper uses jsDelivr to download precompiled ESM assets, hence avoiding the need for NodeJS locally. For Bootstrap, there's no explicit CSS import, but I can add it manually into the Symfony Asset Manager configuration, importing As of now, I'm using your package without CSS, but if I would want to add it, I would need it; I don't know how to handle the different versions though... |
If manually adding a path is an option, have you tried that with |
Given that we added a |
Bug description
I'm trying to use this package with the Symfony Asset Mapper, which leverages ESM loading to avoid Node/npm as a requirement. This seems to work well with your package, except for the fact that the CSS dist file is not mapped in the
package.json
, so ESM does not see that.Expected behavior
CSS is included in the package, so that CDNs like jsDelivr will consider it and add to the needed files.
Steps to reproduce
Additional context
The Symfony docs refer to the package.json configuration file as a way to fix this; we probably need to add keys like
sass
orstyle
to the root of thepackage.json
, like Bootstrap does: https://github.com/twbs/bootstrap/blob/e3e00b5002139adb0d5dadd6002e15b7b6cd371f/package.json#L40The text was updated successfully, but these errors were encountered: