Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Social class with an equivalent MenuItem #291

Open
cjbrooks12 opened this issue Jul 16, 2019 · 0 comments
Open

Replace Social class with an equivalent MenuItem #291

cjbrooks12 opened this issue Jul 16, 2019 · 0 comments
Labels
core Project Type: Core functionality enhancement Task Type: New features, additional options for existing features, etc. good first issue refactor Task Type: Refactoring, code cleanup, etc. themes Project Type: Themes

Comments

@cjbrooks12
Copy link
Contributor

The Social class feels kinda strange and out-of-place. It works mostly like a menu, but is much more limited. Instead, let's just replace that class with a new SocialMenuItem, with similar parameters and usage as the existing Social class and its items.

The theme templates will need to be updated, so that the current "social" areas reference a new OrchidMenu and render with the updated formatting
@cjbrooks12 cjbrooks12 added enhancement Task Type: New features, additional options for existing features, etc. core Project Type: Core functionality refactor Task Type: Refactoring, code cleanup, etc. themes Project Type: Themes good first issue labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Project Type: Core functionality enhancement Task Type: New features, additional options for existing features, etc. good first issue refactor Task Type: Refactoring, code cleanup, etc. themes Project Type: Themes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjbrooks12