Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate search database from Python -> Go #79

Open
3 tasks
orblivion opened this issue Apr 30, 2024 · 0 comments
Open
3 tasks

Migrate search database from Python -> Go #79

orblivion opened this issue Apr 30, 2024 · 0 comments

Comments

@orblivion
Copy link
Owner

See the description of the associated milestone for some technical background.

  • This task will be for migrating the search database interactions from the Python server to the Go server. Look for anything that says search_db_path. Move it along with the associated sql statements to Go. Feel free to pull in whatever surrounding code that's straightforward enough to move to Go along with the sql. So long as it's well organized on the Go side.

  • Expose whatever you move to Go as internal endpoints and call them from Python, deleting the replaced code.

You could look at the bookmark database access stuff (separate sqlite file) under go/ for some reference, though it's still in progress as of this writing.

  • Please add tests and stuff as well of course. However, I would not take the time to write tests for the internal http handler functions as such, since http tests are annoying and we'll be stripping those handlers away soon anyway. But everything else, go ahead and test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant