Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tile generation #19

Open
1 task done
orblivion opened this issue Mar 1, 2023 · 1 comment
Open
1 task done

Improve tile generation #19

orblivion opened this issue Mar 1, 2023 · 1 comment
Labels
visible map Related to map data or rendering

Comments

@orblivion
Copy link
Owner

orblivion commented Mar 1, 2023

Protomaps (the vector rendering library I use) doesn't seem to support footpaths/pedestrian roads at all, if you look at their leaflet demo linked from the github for protomaps.js. Ideally I think they should show up as dotted lines or something.

At some point I decided to generate those paths as roads as a holdover, but in retrospect that's going to give people the wrong idea. For Launch, let's remove pedestrian/footpath ways altogether to match what Protomaps has. For the future, I think I could add support to protomaps.js, and upstream it if they want.

- [ ] Remove footpaths/pedestrian roads from tile generation for Launch.

As for the rest, I think we could skip for launch, unless we see something bad and obvious.

  • Post-Launch, add footpaths/pedestrian roads back to tile generation, and add support for them as a dotted line in protomaps.js

Post-Launch

  • Water in some places is broken. In particular, look at NYC. Maybe it has to do with misinterpreting the ferry lines as areas? Maybe we could just axe those.
  • Make the tiles look good and somewhat follow the Protomaps.js spec
  • Add the .shp files for land use etc that the tilemaker configs want to use. (maybe)
  • Hide POIs when sufficiently zoomed out.
  • Trails, pedestrian paths, cycle paths, etc, now show up as as a dark red dotted line.
    • This is due to a patch I made on top of protomaps.js
    • Contribute the changes back to Protomaps? Not too likely. The other protomaps renderer (not for Leaflet) actually has these, so it's probably on their radar for the leaflet version.
    • Get feedback?
    • Separate "urban" from "rural" paths. The latter should stay red.
  • Delete anything in the mbtiles configs that I'm not using. All unused attributes ("class" etc) should be gone. That could shrink the output files a little actually.
@orblivion orblivion added this to the Launch milestone May 16, 2023
@orblivion orblivion removed the launch label May 16, 2023
@orblivion
Copy link
Owner Author

I went ahead and added footpaths to protomaps.js. Wasn't hard. Generated new maps, available in the appVersion 24.

The rest of this issue will be post-launch!

@orblivion orblivion removed this from the Launch milestone Aug 14, 2023
@orblivion orblivion added the visible map Related to map data or rendering label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visible map Related to map data or rendering
Projects
None yet
Development

No branches or pull requests

1 participant