Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

Change log.tails and log.heads to both return hashes and add get methods for Entries #218

Open
shamb0t opened this issue Jan 8, 2019 · 2 comments

Comments

@shamb0t
Copy link
Contributor

shamb0t commented Jan 8, 2019

@satazor has pointed out that currently log.heads return hashes (or cids), log.tails return entries and log.tailHashes (or soon log.tailCids) return hashes/cids while it makes more sense for log.heads and log.tails to return hashes/cids and have log.headEntries and log.tailEntries to return entries. We can track discussion and those changes here.

@aphelionz
Copy link
Contributor

Will we be dropping tails soon since Log.values traverses the log? That might simplify the discussion and decision here.

@aphelionz aphelionz self-assigned this Jan 26, 2019
@aphelionz aphelionz removed their assignment Feb 5, 2019
@aphelionz
Copy link
Contributor

Removing my assignment as I'm not currently working on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants