Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pushing based on temporary file store path #996

Merged
merged 16 commits into from
Jul 4, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jun 29, 2023

What this PR does / why we need it:
This PR fixes issue of temporary file remained in the local working directory.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #995

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #996 (523e434) into main (ba60b99) will decrease coverage by 0.18%.
The diff coverage is 65.85%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   81.39%   81.21%   -0.18%     
==========================================
  Files          54       55       +1     
  Lines        2816     2848      +32     
==========================================
+ Hits         2292     2313      +21     
- Misses        355      365      +10     
- Partials      169      170       +1     
Impacted Files Coverage Δ
internal/contentutil/target.go 63.33% <63.33%> (ø)
cmd/oras/root/push.go 74.13% <72.72%> (+0.30%) ⬆️

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion

cmd/oras/root/push.go Outdated Show resolved Hide resolved
cmd/oras/root/file.go Outdated Show resolved Hide resolved
cmd/oras/root/push.go Outdated Show resolved Hide resolved
cmd/oras/root/push.go Outdated Show resolved Hide resolved
cmd/oras/root/push.go Outdated Show resolved Hide resolved
cmd/oras/root/push.go Outdated Show resolved Hide resolved
cmd/oras/root/push.go Outdated Show resolved Hide resolved
qweeah added 3 commits June 30, 2023 06:39
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
internal/store/hybrid.go Outdated Show resolved Hide resolved
internal/store/hybrid.go Outdated Show resolved Hide resolved
cmd/oras/root/push.go Outdated Show resolved Hide resolved
qweeah added 8 commits July 3, 2023 05:10
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit e5a7c2e into oras-project:main Jul 4, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oras push generate manifest unwanted file
5 participants