Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify command contexts #899

Merged
merged 11 commits into from
Apr 6, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Mar 23, 2023

What this PR does / why we need it:
Makes all oras commands executed based on the same context passed from root command. Depends on merging of #825

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #824

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@qweeah qweeah marked this pull request as draft March 23, 2023 06:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #899 (cb0bbd3) into main (60eec26) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
- Coverage   67.79%   67.63%   -0.16%     
==========================================
  Files          22       22              
  Lines         860      862       +2     
==========================================
  Hits          583      583              
- Misses        232      234       +2     
  Partials       45       45              
Impacted Files Coverage Δ
cmd/oras/internal/option/common.go 60.00% <0.00%> (-40.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qweeah qweeah force-pushed the standardize-context branch from ddf80ab to f965cd6 Compare March 30, 2023 02:56
@qweeah qweeah marked this pull request as ready for review March 30, 2023 02:56
@qweeah qweeah force-pushed the standardize-context branch from f965cd6 to d37714d Compare March 30, 2023 15:30
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/oras/root/attach.go Outdated Show resolved Hide resolved
cmd/oras/root/attach.go Outdated Show resolved Hide resolved
@qweeah qweeah force-pushed the standardize-context branch from d37714d to 153275d Compare April 6, 2023 02:00
qweeah added 9 commits April 6, 2023 02:01
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah force-pushed the standardize-context branch from 153275d to e77ec04 Compare April 6, 2023 02:01
qweeah added 2 commits April 6, 2023 02:02
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants