Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add basic PR template #778

Merged
merged 1 commit into from
Feb 22, 2023
Merged

chore: Add basic PR template #778

merged 1 commit into from
Feb 22, 2023

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:
Add a PR template so contributors have some guidelines.

@TerryHowe TerryHowe force-pushed the propose-pr-template branch from 22cf9a2 to 0d7f5aa Compare February 3, 2023 02:35
@shizhMSFT shizhMSFT requested a review from FeynmanZhou February 3, 2023 13:20
@shizhMSFT
Copy link
Contributor

Thank @TerryHowe for contributing the initial PR template.

We do have a reviewing guide that applies to all pull requests. Meanwhile, we follow the conventional commits for the PR titles.

@TerryHowe
Copy link
Member Author

We do have a reviewing guide that applies to all pull requests. Meanwhile, we follow the conventional commits for the PR titles.

These sound like good items to have in the contribution guide, but it isn't entirely clear they should be in the PR template.

@TerryHowe TerryHowe force-pushed the propose-pr-template branch from 0d7f5aa to d60592e Compare February 4, 2023 15:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023 •
edited
Loading

Codecov Report

Merging #778 (e09ca18) into main (d6240d6) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #778   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files          23       23           
  Lines         935      935           
=======================================
  Hits          519      519           
  Misses        374      374           
  Partials       42       42

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TerryHowe TerryHowe force-pushed the propose-pr-template branch from d60592e to 309fb1f Compare February 4, 2023 15:51
@TerryHowe TerryHowe changed the title Add basic PR template docs: Add basic PR template Feb 4, 2023
@TerryHowe TerryHowe changed the title docs: Add basic PR template chore: Add basic PR template Feb 4, 2023
@TerryHowe
Copy link
Member Author

All subjects update for this repo at least

FeynmanZhou
FeynmanZhou approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TerryHowe Thanks for adding a basic PR template. It looks good. Can we add one more question to this template?

@TerryHowe TerryHowe force-pushed the propose-pr-template branch from 309fb1f to 0b08086 Compare February 6, 2023 16:21
@TerryHowe
Copy link
Member Author

@TerryHowe Thanks for adding a basic PR template. It looks good. Can we add one more question to this template?

I added the check boxes you requested. Was there something else? Thanks.

FeynmanZhou
FeynmanZhou approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc @oras-project/oras-maintainers

qweeah
qweeah approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and I just applied to all my PRs👍）

shizhMSFT
shizhMSFT approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a basic PR template

@shizhMSFT shizhMSFT merged commit 8995628 into oras-project:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@qweeah qweeah qweeah approved these changes

@deitch deitch Awaiting requested review from deitch

@jdolitsky jdolitsky Awaiting requested review from jdolitsky

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TerryHowe @shizhMSFT @codecov-commenter @qweeah @FeynmanZhou