Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only pull configuration in root #684

Merged
merged 29 commits into from
Nov 14, 2022
Merged

fix: only pull configuration in root #684

merged 29 commits into from
Nov 14, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 9, 2022 •
edited
Loading

Resolves #682

Signed-off-by: Billy Zha [email protected]

@qweeah qweeah marked this pull request as draft November 9, 2022 08:37
@qweeah qweeah marked this pull request as ready for review November 9, 2022 08:47
qweeah added 3 commits November 9, 2022 16:55
@qweeah
remove duplicated log
d078d54 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
fix bug
05365e8 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
fix matching
3436a4d 
Signed-off-by: Billy Zha <[email protected]>
Wwwsylvia
Wwwsylvia reviewed Nov 9, 2022
View reviewed changes
cmd/oras/pull.go Outdated Show resolved Hide resolved
internal/content/graph.go Outdated Show resolved Hide resolved
internal/content/graph.go Outdated Show resolved Hide resolved
internal/content/graph.go Outdated Show resolved Hide resolved
internal/content/graph.go Outdated Show resolved Hide resolved
qweeah added 6 commits November 9, 2022 22:25
@qweeah
change package name
6b7a090 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
separate docker and oci image
a2ee92b 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
refactored & add skip subject
c959668 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
use pointer for config
b4ec47b 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
bug fix
056bad7 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
comment clean
012fd6e 
Signed-off-by: Billy Zha <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #684 (a109092) into main (77331c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          14       14           
  Lines         513      513           
=======================================
  Hits          370      370           
  Misses        114      114           
  Partials       29       29

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qweeah qweeah changed the title fix: only pull config once for root manifest fix: only pull one configuration and support selective sujbect pullling Nov 10, 2022
@qweeah qweeah requested a review from Wwwsylvia November 10, 2022 06:16
@qweeah
merged docker and oci manifest
e9b7f5b 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
only download root config
8677387 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
bugfix
3bd369c 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
fix bug
0cd7f2f 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah requested a review from shizhMSFT November 10, 2022 08:35
shizhMSFT
shizhMSFT reviewed Nov 10, 2022
View reviewed changes
cmd/oras/pull.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Nov 10, 2022
View reviewed changes
internal/graph/graph.go Outdated Show resolved Hide resolved
cmd/oras/pull.go Outdated Show resolved Hide resolved
cmd/oras/pull.go Outdated Show resolved Hide resolved
cmd/oras/pull.go Outdated Show resolved Hide resolved
@qweeah
check error
91c1468 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
code clean
d65abea 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
remove named parameters
b50aa23 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
revert subject flag
6e8c3f5 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
remove subject
c80d9dd 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah changed the title fix: only pull one configuration and support selective sujbect pullling fix: only pull configuration in root Nov 11, 2022
@qweeah
include subject by default
a109092 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
use sync.Once
944b61c 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
code clean
66cf83e 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
correct comments
88ad486 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
comment clean
7e05f9b 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
removed comments
98d4b81 
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
shizhMSFT approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2329c6e into oras-project:main Nov 14, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
@qweeah
fix: only pull configuration in root (oras-project#684)
adbe75f 
Resolves oras-project#682

Signed-off-by: Billy Zha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@Wwwsylvia Wwwsylvia Awaiting requested review from Wwwsylvia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oras pull fails when --config is used and there is more than one config in the reference tree
4 participants
@qweeah @codecov-commenter @Wwwsylvia @shizhMSFT