From ee986bf98855e6d0f8428aa1266604fa455c6553 Mon Sep 17 00:00:00 2001 From: Billy Zha Date: Thu, 22 Sep 2022 16:39:28 +0800 Subject: [PATCH 1/4] fix: update argument description for platform Signed-off-by: Billy Zha --- cmd/oras/internal/option/platform.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/oras/internal/option/platform.go b/cmd/oras/internal/option/platform.go index 54d9df8bb..62d0984a4 100644 --- a/cmd/oras/internal/option/platform.go +++ b/cmd/oras/internal/option/platform.go @@ -31,7 +31,7 @@ type Platform struct { // ApplyFlags applies flags to a command flag set. func (opts *Platform) ApplyFlags(fs *pflag.FlagSet) { - fs.StringVarP(&opts.Platform, "platform", "", "", "fetch the manifest of a specific platform if target is multi-platform capable") + fs.StringVarP(&opts.Platform, "platform", "", "", "only fetch a specific platform if target is multi-platform capable, in the form of os[/arch][/variant][:os_version])") } // parse parses the input platform flag to an oci platform type. From 0a7449a397f2e73f8e115bbb06b6f9bc8acd0bc1 Mon Sep 17 00:00:00 2001 From: Billy Zha Date: Thu, 22 Sep 2022 16:52:42 +0800 Subject: [PATCH 2/4] update description Signed-off-by: Billy Zha --- cmd/oras/internal/option/platform.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/oras/internal/option/platform.go b/cmd/oras/internal/option/platform.go index 62d0984a4..dd7a61295 100644 --- a/cmd/oras/internal/option/platform.go +++ b/cmd/oras/internal/option/platform.go @@ -31,7 +31,7 @@ type Platform struct { // ApplyFlags applies flags to a command flag set. func (opts *Platform) ApplyFlags(fs *pflag.FlagSet) { - fs.StringVarP(&opts.Platform, "platform", "", "", "only fetch a specific platform if target is multi-platform capable, in the form of os[/arch][/variant][:os_version])") + fs.StringVarP(&opts.Platform, "platform", "", "", "specifies the platform in the form of os[/arch][/variant][:os_version]") } // parse parses the input platform flag to an oci platform type. From 9e3816da768c597c0d71e7f110ae2ea4f40bf82f Mon Sep 17 00:00:00 2001 From: Billy Zha Date: Thu, 22 Sep 2022 22:25:12 +0800 Subject: [PATCH 3/4] resolve comment Signed-off-by: Billy Zha --- cmd/oras/internal/option/platform.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/oras/internal/option/platform.go b/cmd/oras/internal/option/platform.go index dd7a61295..b1b787bf6 100644 --- a/cmd/oras/internal/option/platform.go +++ b/cmd/oras/internal/option/platform.go @@ -31,7 +31,7 @@ type Platform struct { // ApplyFlags applies flags to a command flag set. func (opts *Platform) ApplyFlags(fs *pflag.FlagSet) { - fs.StringVarP(&opts.Platform, "platform", "", "", "specifies the platform in the form of os[/arch][/variant][:os_version]") + fs.StringVarP(&opts.Platform, "platform", "", "", "ensure fetching a manifest of a platform in the form of os[/arch][/variant][:os_version]") } // parse parses the input platform flag to an oci platform type. From 4662a880d8d32419067423c55afa3ccf042ac008 Mon Sep 17 00:00:00 2001 From: Billy Zha Date: Fri, 23 Sep 2022 15:15:17 +0800 Subject: [PATCH 4/4] rephrased Signed-off-by: Billy Zha --- cmd/oras/internal/option/platform.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/oras/internal/option/platform.go b/cmd/oras/internal/option/platform.go index b1b787bf6..64736487f 100644 --- a/cmd/oras/internal/option/platform.go +++ b/cmd/oras/internal/option/platform.go @@ -31,7 +31,7 @@ type Platform struct { // ApplyFlags applies flags to a command flag set. func (opts *Platform) ApplyFlags(fs *pflag.FlagSet) { - fs.StringVarP(&opts.Platform, "platform", "", "", "ensure fetching a manifest of a platform in the form of os[/arch][/variant][:os_version]") + fs.StringVarP(&opts.Platform, "platform", "", "", "request platform in the form of `os[/arch][/variant][:os_version]`") } // parse parses the input platform flag to an oci platform type.