feat: support fetch a blob from a remote registry #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 70.78% 70.79% +0.01%
==========================================
Files 11 11
Lines 421 428 +7
==========================================
+ Hits 298 303 +5
- Misses 100 101 +1
- Partials 23 24 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nima
reviewed
Aug 26, 2022
nima
reviewed
Aug 26, 2022
nima
reviewed
Aug 26, 2022
nima
reviewed
Aug 26, 2022
Wwwsylvia
reviewed
Sep 1, 2022
shizhMSFT
reviewed
Sep 1, 2022
yuehaoliang
reviewed
Sep 2, 2022
Wwwsylvia
reviewed
Sep 2, 2022
lizMSFT
force-pushed
the
liz/475
branch
13 times, most recently
from
3089a08 to
097dc7f
Compare
qweeah
reviewed
Sep 8, 2022
qweeah
reviewed
Sep 8, 2022
lizMSFT
force-pushed
the
liz/475
branch
2 times, most recently
from
defc485 to
f400dd7
Compare
Signed-off-by: Zoey Li <[email protected]>
Signed-off-by: Zoey Li <[email protected]>
Signed-off-by: Zoey Li <[email protected]>
Signed-off-by: Zoey Li <[email protected]>
Signed-off-by: Zoey Li <[email protected]>
Signed-off-by: Zoey Li <[email protected]>
Signed-off-by: Zoey Li <[email protected]>
shizhMSFT
requested changes
Sep 8, 2022
cmd/oras/blob/fetch.go
Outdated
| } | ||
|
|
||
| // fetch blob | ||
| desc, rc, err := oras.Fetch(ctx, src, opts.targetRef, oras.FetchOptions{}) |
There was a problem hiding this comment.
It seems the rc is never verified against the desc.
There was a problem hiding this comment.
create an issue to track this #547
Signed-off-by: Zoey Li <[email protected]>
Signed-off-by: Zoey Li <[email protected]>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Zoey Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support fetch a blob from a remote registry
Resolves: #475
Signed-off-by: Zoey Li [email protected]