-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: --output for oras manifest index create
#1490
Conversation
index create
index create
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
+ Coverage 85.73% 85.83% +0.09%
==========================================
Files 116 116
Lines 4059 4073 +14
==========================================
+ Hits 3480 3496 +16
+ Misses 347 345 -2
Partials 232 232 ☔ View full report in Codecov by Sentry. |
fbbc807
to
a61f83d
Compare
index create
oras manifest index create
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
23e5ab1
to
12a8e6b
Compare
Signed-off-by: Xiaoxuan Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shouldn't |
Is it necessary? |
I think it's intuitive and conventional. E.g. |
What this PR does / why we need it:
current output:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #1053
Please check the following list: