Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --output for oras manifest index create #1490

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Aug 29, 2024

What this PR does / why we need it:

current output:

oras manifest index create myregistry.azurecr.io/test sha256:42c524c48e0672568dbd2842d3a0cb34a415347145ee9fe1c8abaf65e7455b46 --output - --pretty
Fetching sha256:42c524c48e0672568dbd2842d3a0cb34a415347145ee9fe1c8abaf65e7455b46
Fetched  sha256:42c524c48e0672568dbd2842d3a0cb34a415347145ee9fe1c8abaf65e7455b46
Packed   f16df862b7e3 application/vnd.oci.image.index.v1+json
Digest: sha256:f16df862b7e3d4f13c03d59655ed25a71a68e01e4aeec0d921d7310d6c67a360
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:42c524c48e0672568dbd2842d3a0cb34a415347145ee9fe1c8abaf65e7455b46",
      "size": 1239,
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    }
  ]
}

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #1053

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@wangxiaoxuan273 wangxiaoxuan273 changed the title Create output feat: --output for index create Aug 29, 2024
@wangxiaoxuan273 wangxiaoxuan273 changed the title feat: --output for index create feat: --export-manifest for index create Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (0baec35) to head (d7055ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   85.73%   85.83%   +0.09%     
==========================================
  Files         116      116              
  Lines        4059     4073      +14     
==========================================
+ Hits         3480     3496      +16     
+ Misses        347      345       -2     
  Partials      232      232              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangxiaoxuan273 wangxiaoxuan273 changed the title feat: --export-manifest for index create feat: --output for oras manifest index create Sep 12, 2024
Xiaoxuan Wang added 4 commits September 12, 2024 18:43
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a3b0601 into oras-project:main Sep 12, 2024
8 checks passed
@qweeah
Copy link
Contributor

qweeah commented Sep 13, 2024

Shouldn't --output - forbids status output?

@wangxiaoxuan273
Copy link
Contributor Author

Shouldn't --output - forbids status output?

Is it necessary?

@qweeah
Copy link
Contributor

qweeah commented Sep 13, 2024

I think it's intuitive and conventional. E.g. curl turns off status output when using -o -.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants