Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reset test coverage package list #1482

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 18, 2024

What this PR does / why we need it:
Before this change, the nested $() in Makefile $(GO_EXE) list ./... | grep -v internal/testutils | tr '\n' ',' generates empty return value so -coverpkg is actually set to ''

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 60b1369 into oras-project:main Aug 18, 2024
6 checks passed
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (7b966eb) to head (4d75b0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   83.43%   85.54%   +2.10%     
==========================================
  Files         113      113              
  Lines        3936     3936              
==========================================
+ Hits         3284     3367      +83     
+ Misses        428      342      -86     
- Partials      224      227       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants