Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move generate content key method to descriptor #1415

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Move GeneerateContentKey to descriptor package and increase test coverage.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.33%. Comparing base (f6440c3) to head (5782e3b).

Current head 5782e3b differs from pull request most recent head f56bda4

Please upload reports for the commit f56bda4 to get more accurate results.

Files Patch % Lines
cmd/oras/root/pull.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files         107      106    -1     
  Lines        3798     3798           
=======================================
  Hits         3241     3241           
  Misses        333      333           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions.

internal/descriptor/descriptor.go Outdated Show resolved Hide resolved
@TerryHowe TerryHowe merged commit 854ccc2 into oras-project:main Jun 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants