-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Increase print test coverage #1411
chore: Increase print test coverage #1411
Conversation
Signed-off-by: Terry Howe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
=======================================
Coverage 85.32% 85.32%
=======================================
Files 107 107
Lines 3795 3795
=======================================
Hits 3238 3238
Misses 333 333
Partials 224 224 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rename test function to be compliant with suggested practices in Golang docs:
E.g. the naming convention to declare examples for the package, a function F, a type T and method M on type T are:
func Example() { ... }
func ExampleF() { ... }
func ExampleT() { ... }
func ExampleT_M() { ... }
Multiple example functions for a package/type/function/method may be provided by appending a distinct suffix to the name. The suffix must start with a lower-case letter.
Co-authored-by: Billy Zha <[email protected]> Signed-off-by: Terry Howe <[email protected]>
Co-authored-by: Billy Zha <[email protected]> Signed-off-by: Terry Howe <[email protected]>
Co-authored-by: Billy Zha <[email protected]> Signed-off-by: Terry Howe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Add more print test coverage