Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move verbose into printer object #1406

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

The verbose option should be owned by the printer.

@TerryHowe TerryHowe force-pushed the refactor-verbose branch 2 times, most recently from 2fdb89c to 40d5625 Compare June 14, 2024 17:19
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (2479698) to head (76d3cfc).

Files Patch % Lines
cmd/oras/root/manifest/push.go 40.00% 0 Missing and 3 partials ⚠️
cmd/oras/internal/display/status/text.go 91.66% 0 Missing and 1 partial ⚠️
cmd/oras/root/blob/push.go 85.71% 0 Missing and 1 partial ⚠️
cmd/oras/root/cp.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1406   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files         107      107           
  Lines        3790     3790           
=======================================
  Hits         3222     3222           
  Misses        339      339           
  Partials      229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/oras/root/cp_test.go Outdated Show resolved Hide resolved
cmd/oras/root/cp_test.go Outdated Show resolved Hide resolved
cmd/oras/root/cp_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions.

@qweeah qweeah merged commit e0b7cdd into oras-project:main Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants