-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move printer to output package #1394
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 107 107
Lines 3804 3804
=======================================
Hits 3236 3236
Misses 339 339
Partials 229 229 ☔ View full report in Codecov by Sentry. |
356b00b
to
873d970
Compare
@TerryHowe What kind of problem is expected to be resolved by this PR? Moving print-related utilities out of Types of output
Taking pull artifact as an example:
$ oras pull --oci-layout hello:latest --no-tty
Downloading a948904f2f0f hello.txt
Downloaded a948904f2f0f hello.txt
Pulled [oci-layout] hello:latest
Digest: sha256:6ca2cbb8dc842320c8b9ae609dfb2f9a83eb0be382cbc0c75c6bbdd51a15b242 Status output:
Metadata output:
|
I just created this PR to give better separation of concerns and avoid possible circular dependencies. The Printer is a like a logging system and really shouldn't be dependent on what it logs. |
@TerryHowe Got it, then this PR should only move |
Signed-off-by: Terry Howe <[email protected]>
873d970
to
f75e979
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
The printer is supposed to be a very generic output object and this change moves in that direction.