Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated PrintStatus method #1389

Merged
merged 1 commit into from
May 27, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Removes deprecated PrintStatus method

@TerryHowe TerryHowe force-pushed the remove-deprecated-printstatus branch from f2f2292 to e5297e7 Compare May 26, 2024 17:13
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.07%. Comparing base (8ec5464) to head (be07a0a).

Files Patch % Lines
cmd/oras/root/manifest/push.go 25.00% 0 Missing and 3 partials ⚠️
cmd/oras/root/blob/push.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1389   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         107      107           
  Lines        3805     3805           
=======================================
  Hits         3237     3237           
  Misses        339      339           
  Partials      229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How could the patch coverage be 73.33% with 0 line missed?

@shizhMSFT shizhMSFT force-pushed the remove-deprecated-printstatus branch from e5297e7 to be07a0a Compare May 27, 2024 05:37
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit fc07c24 into oras-project:main May 27, 2024
7 of 8 checks passed
ti-chi-bot bot referenced this pull request in PingCAP-QE/artifacts Jul 5, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [oras-project/oras](https://togithub.com/oras-project/oras) | minor |
`v1.1.0` -> `v1.2.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>oras-project/oras (oras-project/oras)</summary>

###
[`v1.2.0`](https://togithub.com/oras-project/oras/releases/tag/v1.2.0)

[Compare
Source](https://togithub.com/oras-project/oras/compare/v1.1.0...v1.2.0)

#### New Features

- `oras` is compliant with OCI [image-spec
v1.1.0](https://togithub.com/opencontainers/image-spec/blob/v1.1.0) and
[distribution-spec
v1.1.0](https://togithub.com/opencontainers/distribution-spec/tree/v1.1.0)
-   Introduce brand-new default terminal experience
    -   Show live progress for the following commands:
        -   `oras copy`
        -   `oras pull`
        -   `oras push`
        -   `oras attach`
        -   `oras blob fetch`
        -   `oras blob push`
- The new terminal experience can be turned off via the preview flag
`--no-tty`
-   Support deletion of manifests and blobs in OCI image layout
-   Support X.509 mTLS authentication with OCI registries

#### Preview Features

- **BREAKING CHANGE** Registries supporting `Referrers API` prior to
[distribution-spec
v1.1.0-rc4](https://togithub.com/opencontainers/distribution-spec/tree/v1.1.0-rc4)
will fall back to `Referrers tag schema`, causing unexpected results of
`oras attach` and `oras discover` commands
- Introduce `--platform` to `oras attach` for better multi-arch
attaching experience, which allows adding referrer artifact to a
specific sub-platform
- Re-purpose the flag `--recursive` of `oras cp` from [extended
copy](https://oras.land/docs/client_libraries/overview#extended-copy) to
copy an artifact or a multi-arch image and its referrers
-   Promote `--image-spec` to a preview flag from experimental

#### Experimental Features

- **BREAKING CHANGE** `oras discover` shows `tree` view output by
default
- Introduce formatted output via `--format` by implementing the
[specification](https://togithub.com/oras-project/oras/blob/v1.2.0/docs/proposals/formatted-output.md)
    -   Formatted output is available to the following commands:
        -   `oras pull`
        -   `oras push`
        -   `oras attach`
        -   `oras discover`
        -   `oras manifest fetch`
    -   Examples:
        -   `--format json` to print operation result as a JSON object
- `--format "go-template={{ .digest }}"` to print the digest of the
manifest using [Go template](https://pkg.go.dev/text/template)
            -   Template can also be specified by `--template`
-   Introduce `oras resolve` to get the digest of an artifact

#### Deprecation

- `oras discover`: `--output` is marked as deprecated and succeeded by
`--format`

#### Bug Fixes

- Fix
[#&#8203;1079](https://togithub.com/oras-project/oras/issues/1079):
Snaps build cannot read default credentials file
- Fix
[#&#8203;1096](https://togithub.com/oras-project/oras/issues/1096):
Mixed request number in the debug mode
- Fix
[#&#8203;1106](https://togithub.com/oras-project/oras/issues/1106): Flag
`--plain-http=false` does not work for local registries
- Fix
[#&#8203;1129](https://togithub.com/oras-project/oras/issues/1129):
`oras cp -r` fails if index has a child manifest as subject
-   Minor fixes

#### Other Changes

-   Improve UX
- `oras discover`: show placeholder when `artifactType` is not presented
in an index referrer
    -   `oras push`: show artifact type when pushing files
- Improve error message based on [ORAS CLI error handling
guildline](https://togithub.com/oras-project/oras/blob/v1.2.0/docs/proposals/error-handling-guideline.md)
- Improve identity token input by a new flag `--identity-token` to
replace `--password` without `--username`
-   Improve performance
- Reduce authentication request count for`oras copy`, `oras manifest
delete`, and `oras blob delete`
- Support blob mounting across repositories in the same registry for
`oras copy`
-   Update dependencies
-   Update to Golang `1.22.3`
-   Minor security enhancements

***

### What's Changed Since RC.1

#### Other Changes

-   Improve documentation
-   Update dependencies

#### Detailed Commits

- bump: tag and release ORAS CLI v1.2.0-rc.1 by
[@&#8203;qweeah](https://togithub.com/qweeah) in
[https://github.com/oras-project/oras/pull/1381](https://togithub.com/oras-project/oras/pull/1381)
- fix: remove non-classic snap plugins by
[@&#8203;qweeah](https://togithub.com/qweeah) in
[https://github.com/oras-project/oras/pull/1383](https://togithub.com/oras-project/oras/pull/1383)
- fix: oras cp documentation by
[@&#8203;TerryHowe](https://togithub.com/TerryHowe) in
[https://github.com/oras-project/oras/pull/1384](https://togithub.com/oras-project/oras/pull/1384)
- build(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oras-project/oras/pull/1385](https://togithub.com/oras-project/oras/pull/1385)
- refactor: Get rid of deprecated PrintStatus method by
[@&#8203;TerryHowe](https://togithub.com/TerryHowe) in
[https://github.com/oras-project/oras/pull/1378](https://togithub.com/oras-project/oras/pull/1378)
- build(deps): bump github.com/onsi/ginkgo/v2 from 2.17.3 to 2.18.0 in
/test/e2e by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oras-project/oras/pull/1388](https://togithub.com/oras-project/oras/pull/1388)
- build(deps): bump github.com/onsi/ginkgo/v2 from 2.18.0 to 2.19.0 in
/test/e2e by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oras-project/oras/pull/1390](https://togithub.com/oras-project/oras/pull/1390)
- chore: Remove deprecated PrintStatus method by
[@&#8203;TerryHowe](https://togithub.com/TerryHowe) in
[https://github.com/oras-project/oras/pull/1389](https://togithub.com/oras-project/oras/pull/1389)
- doc: verify local files by
[@&#8203;qweeah](https://togithub.com/qweeah) in
[https://github.com/oras-project/oras/pull/1386](https://togithub.com/oras-project/oras/pull/1386)
- fix: remove call to deprecated print by
[@&#8203;TerryHowe](https://togithub.com/TerryHowe) in
[https://github.com/oras-project/oras/pull/1392](https://togithub.com/oras-project/oras/pull/1392)

**Full Changelog**:
oras-project/oras@v1.2.0-rc.1...v1.2.0

#### Notes

This release was signed with `46D3 369B 393F 6F82 71FD 1CE8 F86E C70D
2B0C 404F` ([@&#8203;qweeah](https://togithub.com/qweeah)'s GPG key)
which can be found [here](https://togithub.com/qweeah.gpg).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/PingCAP-QE/artifacts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJoZWxwIHdhbnRlZCJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants