Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ux): optimize progress bar #1349

Merged
merged 9 commits into from
Apr 17, 2024
Merged

chore(ux): optimize progress bar #1349

merged 9 commits into from
Apr 17, 2024

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Apr 16, 2024 •
edited
Loading

This PR

  1. Adds defensive code to avoid showing negative speed in progress bar.
  2. Calculates the download speed based on the size of transferred data in the past last seconds.

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (7ffe63e) to head (84c4cb3).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
+ Coverage   84.49%   84.70%   +0.20%     
==========================================
  Files         103      104       +1     
  Lines        3677     3688      +11     
==========================================
+ Hits         3107     3124      +17     
+ Misses        340      336       -4     
+ Partials      230      228       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah added 2 commits April 16, 2024 07:35
@qweeah
add test
2cca6c7 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
ux: calculate speed in a time window
1eda904 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah changed the title fix: avoid showing negative speed in progress bar chore(ux): optimize progress bar Apr 16, 2024
qweeah added 2 commits April 16, 2024 08:00
@qweeah
code clean
0e5413d 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
add unit test
32c874e 
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
shizhMSFT approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 2edebad into oras-project:main Apr 17, 2024
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@qweeah @FeynmanZhou
chore(ux): optimize progress bar (oras-project#1349)
8d20c45 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qweeah @shizhMSFT