-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: oras push should return error when artifacttype is empty for spec 1.1 #1317
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
+ Coverage 84.06% 84.10% +0.04%
==========================================
Files 90 90
Lines 3458 3467 +9
==========================================
+ Hits 2907 2916 +9
Misses 329 329
Partials 222 222 ☔ View full report in Codecov by Sentry. |
…c 1.1 Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Xiaoxuan Wang <[email protected]>
…c 1.1 (oras-project#1317) Signed-off-by: Xiaoxuan Wang <[email protected]>
What this PR does / why we need it:
oras push
should return an error when--config
is used,--artifact-type
is not used and--image-spec
is set tov1.1
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1313
Please check the following list: