Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(unit): exclude darwin from go build constraint #1289

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Mar 14, 2024

What this PR does / why we need it:
Removed darwin from go build constraint for pty-related operations. Tested on arm64 Mac and the tests pass.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1277

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (d2cca28) to head (6cc1437).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
- Coverage   81.97%   81.92%   -0.06%     
==========================================
  Files          83       83              
  Lines        3995     3995              
==========================================
- Hits         3275     3273       -2     
- Misses        497      499       +2     
  Partials      223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah changed the title fix: exclude darwin from go build constraint test(unit): exclude darwin from go build constraint Mar 14, 2024
@qweeah qweeah merged commit 777d750 into oras-project:main Mar 14, 2024
8 checks passed
@wangxiaoxuan273 wangxiaoxuan273 deleted the arm64 branch March 14, 2024 05:00
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fail on ARM with "fatal error: traceback did not unwind completely"
2 participants