-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): add spec to cover legacy docker config file #1206
Conversation
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
- Coverage 80.30% 80.06% -0.25%
==========================================
Files 66 66
Lines 3646 3646
==========================================
- Hits 2928 2919 -9
- Misses 503 513 +10
+ Partials 215 214 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billy Zha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…1206) Signed-off-by: Billy Zha <[email protected]> Signed-off-by: Feynman Zhou <[email protected]>
What this PR does / why we need it:
This PR adds a new e2e test spec to cover legacy docker config file.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #1204