Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support manifest and blob deletion for OCI layout #1197

Merged
merged 9 commits into from
Dec 11, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 30, 2023

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #761, fixes #762

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (304c9c6) 80.36% compared to head (677c9b9) 80.30%.

Files Patch % Lines
cmd/oras/internal/option/target.go 85.71% 4 Missing and 1 partial ⚠️
cmd/oras/root/blob/delete.go 70.00% 2 Missing and 1 partial ⚠️
cmd/oras/root/manifest/delete.go 90.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
- Coverage   80.36%   80.30%   -0.07%     
==========================================
  Files          66       66              
  Lines        3622     3646      +24     
==========================================
+ Hits         2911     2928      +17     
- Misses        497      503       +6     
- Partials      214      215       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

cmd/oras/internal/option/target.go Outdated Show resolved Hide resolved
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah merged commit abe0ce5 into oras-project:main Dec 11, 2023
6 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support OCI image layout target in oras manifest delete support OCI image layout target in oras blob delete
4 participants