Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align naming of pack option to oras-go #1073

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 23, 2023

This PR updates the pack option of image spec from PackType to PackVersion

@codecov-commenter
Copy link

Codecov Report

Merging #1073 (dacbf84) into main (6319416) will not change coverage.
The diff coverage is 75.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files          56       56           
  Lines        2914     2914           
=======================================
  Hits         2331     2331           
  Misses        405      405           
  Partials      178      178           
Files Changed Coverage Δ
cmd/oras/internal/option/spec.go 85.18% <50.00%> (ø)
cmd/oras/root/push.go 75.00% <100.00%> (ø)

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 49f58ab into oras-project:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants