Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pack OCI image spec v1.1 manifests #1054

Merged
merged 27 commits into from
Aug 18, 2023
Merged

feat: pack OCI image spec v1.1 manifests #1054

merged 27 commits into from
Aug 18, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 8, 2023 •
edited
Loading

Fixes #1043, fixes #1062

@qweeah qweeah marked this pull request as draft August 8, 2023 03:33
@qweeah qweeah mentioned this pull request Aug 9, 2023
Merged
qweeah added 2 commits August 9, 2023 03:22
@qweeah
fix artifact push without subject
e298234 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
add data
3e03906 
Signed-off-by: Billy Zha <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 63.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (0e2e0f3) to head (0c382f4).
Report is 296 commits behind head on main.

Files with missing lines Patch % Lines
internal/graph/graph.go 55.55% 12 Missing and 4 partials ⚠️
cmd/oras/internal/option/spec.go 57.14% 3 Missing ⚠️
cmd/oras/root/push.go 76.92% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   80.97%   79.94%   -1.04%     
==========================================
  Files          56       56              
  Lines        2891     2897       +6     
==========================================
- Hits         2341     2316      -25     
- Misses        375      404      +29     
- Partials      175      177       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah marked this pull request as ready for review August 10, 2023 01:53
shizhMSFT
shizhMSFT reviewed Aug 10, 2023
View reviewed changes
cmd/oras/internal/option/spec.go Outdated Show resolved Hide resolved
cmd/oras/root/push.go Outdated Show resolved Hide resolved
internal/graph/graph.go Show resolved Hide resolved
@qweeah
add index support
7cc3bf8 
Signed-off-by: Billy Zha <[email protected]>
qweeah added 2 commits August 10, 2023 16:07
@qweeah
resolve comment
788398b 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
remove duplicated function
93d7a8a 
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
shizhMSFT reviewed Aug 11, 2023
View reviewed changes
internal/graph/graph.go Outdated Show resolved Hide resolved
cmd/oras/root/push.go Outdated Show resolved Hide resolved
cmd/oras/root/cp.go Show resolved Hide resolved
internal/graph/graph.go Show resolved Hide resolved
qweeah added 2 commits August 14, 2023 00:40
@qweeah
resolve comment
fc8d263 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
resolve comment
a854802 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
resolve comment
240dc6b 
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
shizhMSFT approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

internal/graph/graph.go Outdated Show resolved Hide resolved
@qweeah
resolve comment
0c382f4 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah requested a review from shizhMSFT August 18, 2023 03:46
@qweeah qweeah merged commit 30abae3 into oras-project:main Aug 18, 2023
@FeynmanZhou FeynmanZhou mentioned this pull request Aug 18, 2023
Closed
This was referenced Aug 24, 2023
Closed
Merged
@jlbutler jlbutler mentioned this pull request Jan 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia left review comments

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable artifact guidance for ORAS update experimental flag image-spec
4 participants
@qweeah @codecov-commenter @Wwwsylvia @shizhMSFT