chore: fix lint warning #1001
Merged
chore: fix lint warning #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kranurag7
requested review from
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
qweeah
requested changes
Jul 4, 2023
|
One of these changes is breaking tests. I assume it is one of the error returns that was being ignored before. |
qweeah
reviewed
Jul 10, 2023
kranurag7
force-pushed
the
error-handling
branch
from
c385d3c to
583db2a
Compare
Signed-off-by: Anurag <[email protected]>
kranurag7
force-pushed
the
error-handling
branch
from
583db2a to
f3d4189
Compare
qweeah
pushed a commit
to qweeah/oras
that referenced
this pull request
Jul 21, 2023
Signed-off-by: Anurag <[email protected]> Signed-off-by: Billy Zha <[email protected]>
qweeah
pushed a commit
to qweeah/oras
that referenced
this pull request
Jul 21, 2023
Signed-off-by: Anurag <[email protected]> Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
pushed a commit
to shizhMSFT/oras
that referenced
this pull request
Aug 3, 2023
Signed-off-by: Anurag <[email protected]>
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ref: #986
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list:
// cc @qweeah