Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public command level methods so users can script in go #807

Closed
1 task
TerryHowe opened this issue Feb 13, 2023 · 4 comments · Fixed by #825
Closed
1 task

Make public command level methods so users can script in go #807

TerryHowe opened this issue Feb 13, 2023 · 4 comments · Fixed by #825
Labels
documentation Documentation related issues enhancement New feature or request
Milestone

Comments

@TerryHowe
Copy link
Member

TerryHowe commented Feb 13, 2023

What is the version of your ORAS CLI

1.0.0

What would you like to be added?

Make cmd level methods public so that users can write scripts in go instead of shell. What would be required to do this is just expose the commands, associated options and some aspects of cmd/oras/internal/option. Users would create options and call the command. For example for oras repo tags, showTagsOptions and showTags would be made public. The user would also need a way to create a Target

Why is this needed for ORAS?

Shell is pretty terrible to write, test and maintain. It would be a lot easier in go.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@TerryHowe TerryHowe added the enhancement New feature or request label Feb 13, 2023
@shizhMSFT
Copy link
Contributor

Linking alternative solution #810

@shizhMSFT shizhMSFT added the documentation Documentation related issues label Feb 14, 2023
@sajayantony
Copy link
Contributor

From previous discussions, anything made public and GA’d should technically be non breaking and also have test coverage. If there is valid ask and the community is able to come to an agreement that this would benefit the project and is ready to cost/implement then it makes sense to prioritize this item.

@shizhMSFT shizhMSFT added this to the v1.1.0 milestone Feb 15, 2023
@shizhMSFT
Copy link
Contributor

Based on the community call, Billy's cobra-based proposal is accepted. To implement, code refactoring work is required.

@qweeah
Copy link
Contributor

qweeah commented Feb 20, 2023

This issue depends on #824.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issues enhancement New feature or request
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants