Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: manifest fetch fails when confirming the platform of a manifest #636

Closed
qweeah opened this issue Oct 9, 2022 · 5 comments · Fixed by #637
Closed

bug: manifest fetch fails when confirming the platform of a manifest #636

qweeah opened this issue Oct 9, 2022 · 5 comments · Fixed by #637
Assignees
@yuehaoliang
Labels
bug Something isn't working
Milestone
v0.15.1

Comments

@qweeah
Copy link
Contributor

qweeah commented Oct 9, 2022 •
edited
Loading

Reproduce step

oras manifest fetch ghcr.io/oras-project/oras@sha256:ec82a074d971186e5c47080b7eb35275e61f7c3be8303d1f891923d0109f239f --platform linux/arm64
# Error: sha256:bd06290a13e684209732bcfd5747f617b601e1d5fef1db0c07266546dd0941e7: not found

Root cause is that the a manifestStore is used for blob(config) fetching
@qweeah qweeah added the bug Something isn't working label Oct 9, 2022
@shizhMSFT shizhMSFT added this to the v0.15.1 milestone Oct 9, 2022
@shizhMSFT
Copy link
Contributor

Let's create a fix to main.

@shizhMSFT shizhMSFT mentioned this issue Oct 9, 2022
Closed
@yuehaoliang
Copy link
Contributor

Why applying --platform arm64/linux will fetch the config of this manifest?

@shizhMSFT
Copy link
Contributor

Why applying --platform arm64/linux will fetch the config of this manifest?

It will check the config file to confirm that it is indeed an image for arm64/linux.

@yuehaoliang
Copy link
Contributor

yuehaoliang commented Oct 9, 2022 •
edited
Loading

Thank you, I understand the root cause of this issue. I previously missed the fact that config file might be fetched inside this callee function. So, the ReadOnlyStorage passed to it shouldn't be a ManifestStore because it needs to fetch the blob.

@shizhMSFT shizhMSFT moved this to In Progress in ORAS-Planning Oct 9, 2022
@yuehaoliang
Copy link
Contributor

After the fix, the above error has been resolved.

image

@yuehaoliang yuehaoliang mentioned this issue Oct 10, 2022
Merged
shizhMSFT pushed a commit that referenced this issue Oct 10, 2022
@yuehaoliang
fix: change to use repo instead of repo.manifest because it needs to …
4cbc6e4 
…fetch a blob (#637)

Resolve #636 

Signed-off-by: Haoliang Yue <[email protected]>
Repository owner moved this from In Progress to Done in ORAS-Planning Oct 10, 2022
qweeah pushed a commit to qweeah/oras that referenced this issue Oct 11, 2022
@yuehaoliang @qweeah
fix: change to use repo instead of repo.manifest because it needs to …
5f6db2a 
…fetch a blob (oras-project#637)

Resolve oras-project#636 

Signed-off-by: Haoliang Yue <[email protected]>
qweeah pushed a commit to qweeah/oras that referenced this issue Oct 13, 2022
@yuehaoliang @qweeah
fix: change to use repo instead of repo.manifest because it needs to …
eb68ba9 
…fetch a blob (oras-project#637)

Resolve oras-project#636 

Signed-off-by: Haoliang Yue <[email protected]>
shizhMSFT pushed a commit that referenced this issue Oct 13, 2022
@yuehaoliang @shizhMSFT
fix: change to use repo instead of repo.manifest because it needs to …
3c89688 
…fetch a blob (#637)

Resolve #636 

Signed-off-by: Haoliang Yue <[email protected]>
TerryHowe pushed a commit to TerryHowe/oras that referenced this issue Feb 2, 2023
@yuehaoliang
fix: change to use repo instead of repo.manifest because it needs to …
b31125d 
…fetch a blob (oras-project#637)

Resolve oras-project#636 

Signed-off-by: Haoliang Yue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuehaoliang yuehaoliang

Labels
bug Something isn't working
Projects
No open projects
ORAS-Planning
Status: Done
Milestone
v0.15.1
Development

Successfully merging a pull request may close this issue.

fix: change to use repo instead of repo.manifest because it needs to fetch a blob yuehaoliang/oras
3 participants
@qweeah @shizhMSFT @yuehaoliang