Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the license header for ORAS and its dependencies #435

Closed
FeynmanZhou opened this issue Jul 4, 2022 · 4 comments · Fixed by #534
Closed

Check the license header for ORAS and its dependencies #435

FeynmanZhou opened this issue Jul 4, 2022 · 4 comments · Fixed by #534
Assignees
Milestone

Comments

@FeynmanZhou
Copy link
Member

FeynmanZhou commented Jul 4, 2022

We need to check license headers and dependencies' licenses for ORAS before the RC.1 release. This is important to align with the open source compliance policy.

SkyWalking-Eyes might be a good tool to implement the license header check and can be integrated into the GitHub Actions workflow.

@shizhMSFT shizhMSFT added this to the v0.15.0 milestone Jul 26, 2022
@shizhMSFT shizhMSFT moved this to Todo in ORAS-Planning Aug 2, 2022
@FeynmanZhou
Copy link
Member Author

FeynmanZhou commented Aug 31, 2022

Two things we need to complete for this issue:

  • Generate a template to generate the summary of dependencies' licenses
  • Add this license check to GitHub Actions

@shizhMSFT
Copy link
Contributor

@jasminetMSFT Could you help this?

@jasminetMSFT
Copy link
Contributor

Sure, I can help with this.

@FeynmanZhou
Copy link
Member Author

FeynmanZhou commented Sep 6, 2022

@oras-project/oras-maintainers

@jasminetMSFT checked the license header for ORAS and its dependencies for ORAS, ORAS-go, and ORAS-py repo using SkyWalking Eye. You can find the scanning results from this doc.

Meanwhile, Jasmine added this check to the GitHub workflow of ORAS in #534 to automatically check the new PRs for license compliance reasons.

The dependencies' licenses are correct. We detected some source code files lack license headers. So the next step is to fix those files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants