Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge features in artifacts branch as experimental features #379

Closed
3 tasks done
shizhMSFT opened this issue May 7, 2022 · 4 comments · Fixed by #425
Closed
3 tasks done

Merge features in artifacts branch as experimental features #379

shizhMSFT opened this issue May 7, 2022 · 4 comments · Fixed by #425
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@shizhMSFT
Copy link
Contributor

shizhMSFT commented May 7, 2022

With oras-go v2, we can "merge" (re-implement) those features in the artifacts branch into main with those features marked as experimental.

Features:

  • oras discover.
  • oras push artifact manifest.
  • oras pull artifact manifest.
@shizhMSFT shizhMSFT added this to the v0.14.0 milestone May 7, 2022
@shizhMSFT shizhMSFT added the enhancement New feature or request label May 7, 2022
@shizhMSFT
Copy link
Contributor Author

@qweeah You may create issues according to this issue.

@qweeah
Copy link
Contributor

qweeah commented Jun 24, 2022

ack

@qweeah
Copy link
Contributor

qweeah commented Jun 28, 2022

Implementation Gaps

Pull

This command already exists in the main branch. Below options are new from the artifacts branch:

Basically there is no extra code needed for the pull command.

Discover

This is a new command, we need to support discovering artifacts linked with a specified reference, with optional artifact type filtering and different formats of output.

Push

This command already exists in the main branch. Below options are new from the artifacts branch:

  • export-manifest: User will use this to save the packed manifest to a local file. We will refetch the manifest from the source file target and write to a file. It would be better if export manifest can be supported native by oras-go manifest packing options.

  • subject and artifact-type: those two options will be removed and re-implemented in Specification for ORAS attach command #424

@shizhMSFT
Copy link
Contributor Author

Closed by #419 and #425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants