Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support insecure registry #109

Closed
pytimer opened this issue Aug 15, 2019 · 1 comment
Closed

Support insecure registry #109

pytimer opened this issue Aug 15, 2019 · 1 comment

Comments

@pytimer
Copy link
Contributor

pytimer commented Aug 15, 2019

Oras version:

$ oras version
Version:        0.6.0
Go version:     go1.12.4
Git commit:     b285197778e05cd348abb8ff50faf0ef7e3554a2
Git tree state: clean

What happened

Now i use oras to login the harbor registry, it failed. The error log:

$ oras login docker.hikcloud:30001
Username: admin
Password:
INFO[0005] Error logging in to v2 endpoint, trying next endpoint: Get https://docker.registry/v2/: x509: certificate has expired or is not yet valid
Error: Get https://docker.registry/v2/: x509: certificate has expired or is not yet valid

I use the docker client and config the insecure-registries, it login successed.

I see the oras code about login, i find the oras can't setting the insecure-registries parameter, so i hope the oras can add this flags when login the registry.

Is it my idea correct? If this idea ok, i can implement this feature.

@jdolitsky
Copy link
Contributor

closed via #110 & #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants