Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have docusaurus presubmit fail if broken links #220

Closed
1 task done
TerryHowe opened this issue Jul 12, 2023 · 3 comments · Fixed by #223
Closed
1 task done

Have docusaurus presubmit fail if broken links #220

TerryHowe opened this issue Jul 12, 2023 · 3 comments · Fixed by #223
Assignees
@asmitbm

Comments

@TerryHowe
Copy link
Member

Code of Conduct

What part of document/web-page on oras.land is affected?

all.

It would be nice to have a presubmit test that validates links

Additional comments?

No response
@TerryHowe
Copy link
Member Author

Hmm facebook/docusaurus#6998 maybe not. Need to look at other alternatives? I don't know much about docusaurus.

@FeynmanZhou
Copy link
Member

I think there should be a broken link check in CI powered by docusaurus. @asmitbm Could you pls help to verify if the broken link check in CI is working properly?

@asmitbm
Copy link
Member

asmitbm commented Jul 13, 2023

I was looking at a few solutions and I came across this issue facebook/docusaurus#3321. I will explore this more and create a PR. Before doing this if previous PRs are merged, that would be helpful as new plugin would require changing all URL based links to relative links.

@asmitbm asmitbm mentioned this issue Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asmitbm asmitbm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add markdown link checker to validate links asmitbm/oras-www
3 participants
@TerryHowe @FeynmanZhou @asmitbm